Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove onCellFocusOut and add documentation for alternative recommended approach. #6300

Closed
Tracked by #3287
joserodolfofreitas opened this issue Sep 27, 2022 · 0 comments · Fixed by #6302
Assignees
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation v6.x

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Sep 27, 2022

Summary 💡

Initially, we considered adding onCellFocusIn, to complement the use case of onCellFocusOut. The internal event cellFocusIn is already in place, so that'd mean just adding a callback API.

It turns out users can't rely on these events to properly track focus on the Data Grid cells.
The recommended approach is through componentProps, like in this codesandbox.

Motivation 🔦

Enables new extensions on the data grid behavior.
It could help on issues like:

@joserodolfofreitas joserodolfofreitas added status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 27, 2022
@joserodolfofreitas joserodolfofreitas moved this to 🆕 Needs refinement in MUI X Data Grid Sep 27, 2022
@joserodolfofreitas joserodolfofreitas moved this from 🆕 Needs refinement to 🏗 In progress in MUI X Data Grid Sep 27, 2022
@joserodolfofreitas joserodolfofreitas moved this from 🏗 In progress to 🔖 Ready in MUI X Data Grid Sep 28, 2022
@joserodolfofreitas joserodolfofreitas changed the title [DataGrid] Add onCellFocusIn prop to add a callback for cellFocusIn [DataGrid] Remove onCellFocusOut and documentation for alternative recommended approach. Sep 28, 2022
@joserodolfofreitas joserodolfofreitas changed the title [DataGrid] Remove onCellFocusOut and documentation for alternative recommended approach. [DataGrid] Remove onCellFocusOut and add documentation for alternative recommended approach. Sep 28, 2022
@joserodolfofreitas joserodolfofreitas added docs Improvements or additions to the documentation breaking change v6.x and removed new feature New feature or request labels Sep 28, 2022
@flaviendelangle flaviendelangle changed the title [DataGrid] Remove onCellFocusOut and add documentation for alternative recommended approach. [data grid] Remove onCellFocusOut and add documentation for alternative recommended approach. Oct 17, 2022
@joserodolfofreitas joserodolfofreitas moved this from 🔖 Ready to 📋 Backlog in MUI X Data Grid Nov 22, 2022
@cherniavskii cherniavskii self-assigned this Dec 23, 2022
cherniavskii added a commit that referenced this issue Jan 12, 2023
@cherniavskii cherniavskii moved this from 📋 Backlog to ✅ Done in MUI X Data Grid Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation v6.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants