Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Remove deprecated constants #11233

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

michelengelen
Copy link
Member

@michelengelen michelengelen commented Nov 29, 2023

Fixes #10705


Changelog

Breaking changes

  • The deprecated constants SUBMIT_FILTER_STROKE_TIME and SUBMIT_FILTER_DATE_STROKE_TIME have been removed from the DataGrid exports. Use the filterDebounceMs prop to customize filter debounce time.

@michelengelen michelengelen added breaking change component: data grid This is the name of the generic UI component, not the React module! v7.x labels Nov 29, 2023
@michelengelen michelengelen self-assigned this Nov 29, 2023
@michelengelen
Copy link
Member Author

@cherniavskii / @romgrk
I kept the vars for SUBMIT_FILTER_STROKE_TIME here:

const SUBMIT_FILTER_STROKE_TIME = DATA_GRID_PRO_PROPS_DEFAULT_VALUES.filterDebounceMs;

@mui-bot
Copy link

mui-bot commented Nov 29, 2023

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff --git a/docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md b/docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md
index 3fe8d7ebb..32b7b3d8e 100644
--- a/docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md
+++ b/docs/data/migration/migration-data-grid-v6/migration-data-grid-v6.md
@@ -153,9 +153,9 @@ Below are described the steps you need to make to migrate from v6 to v7.
 
 - -->
 
-<!-- ### Other exports
+### Other exports
 
-- -->
+- The deprecated constants `SUBMIT_FILTER_STROKE_TIME` and `SUBMIT_FILTER_DATE_STROKE_TIME` are no longer exported. Use the [`filterDebounceMs`](/x/api/data-grid/data-grid/#DataGrid-prop-filterDebounceMs) prop to customize filter debounce time.
 
 <!-- ### CSS classes

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 29, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@michelengelen michelengelen enabled auto-merge (squash) November 29, 2023 17:00
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 29, 2023
@michelengelen michelengelen merged commit 6bd86f5 into mui:next Nov 29, 2023
2 checks passed
@michelengelen michelengelen deleted the data-grid/10705 branch November 29, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[datagrid] Remove the deprecated SUBMIT_FILTER_STROKE_TIME constant
4 participants