Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fields] Make PickersTextField and its dependencies public #11581

Merged
merged 12 commits into from
Jan 12, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 5, 2024

Extracted from #10649

  • Make PickersTextField, PickersInputBase, PickersInput, PickersOutlinedInput and PickersFilledInput public
  • Add theme augmentation for all these components
  • Rename PickersInput => PickersInputBase and PickersStandardInput => PickersInput to follow the exact same component naming convention as the core (it helps the migration IMHO)
  • Fix the classes applied to each input component

@flaviendelangle flaviendelangle self-assigned this Jan 5, 2024
@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Jan 5, 2024
@mui-bot
Copy link

mui-bot commented Jan 5, 2024

@flaviendelangle flaviendelangle force-pushed the public-pickerstextfield branch from cd8c9a9 to 3e2c251 Compare January 5, 2024 09:51
@flaviendelangle flaviendelangle changed the title [fields] Make PickersTextField and its dependencies public [fields] Make PickersTextField and its dependencies public Jan 5, 2024
@flaviendelangle flaviendelangle force-pushed the public-pickerstextfield branch from d2f28f9 to c47ccf7 Compare January 8, 2024 07:46
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

flaviendelangle and others added 3 commits January 12, 2024 14:07
…ersInput.tsx

Co-authored-by: Lukas <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
…pickersInputBaseClasses.ts

Co-authored-by: Lukas <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
flaviendelangle and others added 2 commits January 12, 2024 14:07
…put/PickersOutlinedInput.tsx

Co-authored-by: Lukas <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
…t/PickersFilledInput.tsx

Co-authored-by: Lukas <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
@flaviendelangle flaviendelangle merged commit f244f22 into mui:next Jan 12, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the public-pickerstextfield branch January 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants