[DataGridPremium] Fix incorrect rows selection count when selection propagation is enabled with row grouping #15216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
bug 🐛
arminmeh
changed the title
arminmeh
changed the title
|
Deploy preview: https://deploy-preview-15216--material-ui-x.netlify.app/ |
MBilalShafi
approved these changes
Oct 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
…ropagation is enabled with row grouping (#15216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15206
The issue occurs when
rowSelectionPropagationis used on a grid with grouped columns and the data is updated.After update, new selection lookup is being created, but the autogenerated rows are being added multiple times to the selection lookup array
Thing is, API to fetch the selection list uses selector that returns a
Map, which removes duplicate values, so the issue is only visible on the count (which operates on the actual array).Now, the selection lookup is rebuilt using the
Mapas well.Duplicate values are coming from checking the parent for selection for each grouped row