-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Experiment with plugins for series+axes #15865
Draft
alexfauquette
wants to merge
20
commits into
mui:master
Choose a base branch
from
alexfauquette:all-pluggin-way
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,283
−3,676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview: https://deploy-preview-15865--material-ui-x.netlify.app/ |
alexfauquette
force-pushed
the
all-pluggin-way
branch
from
December 12, 2024 17:28
afd23e6
to
d17f173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to migrate the axes, series and zoom to the plugin framework.
Modifications
The
plugins
props which was an array of configuration objects, defining for each series how to compute the extremums, preprocess the data, ... is now an object called seriesConfig. That's only sementic modificationI did not yet implemented the colorGetter management. Which causes tootltip colors to be black.
The data modification is now done in selectors. We have 3 states: series, cartesianAxes, and zoom which describe the state of the chart.
One issue with this strategy is that
useXAxis()
is defined in the MIT package. And I we want to have theBarPlot
that supports zoom, we need to have the zoom selectors that support zoom. The workaround is to put typing, and selectors for zoom in the MIT package, but populate and manage the state in the pro package.Unsolved issue
I do not manage to have the controlled/uncontroled zoom working fluently.
I noticed that the actual
onZoomChange
is not really a control callback, because it returns the updater and not the new value