Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix outdated description of GridRowParams.getValue #1731

Merged
merged 3 commits into from
May 28, 2021
Merged

[docs] Fix outdated description of GridRowParams.getValue #1731

merged 3 commits into from
May 28, 2021

Conversation

visshaljagtap
Copy link
Contributor

No description provided.

@visshaljagtap visshaljagtap changed the title Undefined issue fix [DataGrid] Undefined issue fix May 22, 2021
@oliviertassinari oliviertassinari mentioned this pull request May 22, 2021
Closed
@oliviertassinari
Copy link
Member

oliviertassinari commented May 22, 2021 •
edited
Loading

Closing as no reproductions was provided.

@visshaljagtap
Copy link
Contributor Author

Hi @oliviertassinari no reproductions means?

@visshaljagtap
Copy link
Contributor Author

Screenshot 2021-05-22 at 7 24 23 PM

was getting this issue

@oliviertassinari oliviertassinari added the status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it label May 22, 2021
@oliviertassinari
Copy link
Member

@visshaljagtap How did you land on this codesandbox?

@visshaljagtap
Copy link
Contributor Author

visshaljagtap commented May 22, 2021 •
edited
Loading

From documentation https://material-ui.com/components/data-grid/

there is option to edit in CodeSandBox

@oliviertassinari
Copy link
Member

oliviertassinari commented May 22, 2021 •
edited
Loading

@visshaljagtap Ok, reload the page then.

@visshaljagtap
Copy link
Contributor Author

Now its working

@visshaljagtap
Copy link
Contributor Author

what was the issue?

@oliviertassinari
Copy link
Member

@visshaljagtap This breaking change was introduced by @dtassone in #1513 and released in v4.0.0-alpha.29.

@visshaljagtap
Copy link
Contributor Author

Okay, thanks @oliviertassinari!

@bgandy94 bgandy94 mentioned this pull request May 27, 2021
Merged
@oliviertassinari oliviertassinari requested a review from dtassone May 27, 2021 22:17
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation and removed status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it labels May 27, 2021
@oliviertassinari
Copy link
Member

I have pushed new commits to fix the places where the documentation is outdated.

@dtassone dtassone merged commit 844058b into mui:master May 28, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Undefined issue fix [docs] Fix outdated description of GridRowParams.getValue May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visshaljagtap @oliviertassinari @dtassone