Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove unwanted localization and colType exports #2791

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Oct 6, 2021

Part of #2227

Breaking changes

  • Stop using constants for colDef types, we have a type GridNativeColTypes so we can directly use the string.
-const isColString = col.type === GRID_STRING_COLUMN_TYPE;
+const isColString = col.type === 'string';

-const isColNumber = col.type === GRID_NUMBER_COLUMN_TYPE;
+const isColNumber = col.type === 'number';

-const isColDate = col.type === GRID_DATE_COLUMN_TYPE;
+const isColDate = col.type === 'date';

-const isColDateTime = col.type === GRID_DATETIME_COLUMN_TYPE;
+const isColDateTime = col.type === 'dateTime';

-const isColBoolean = col.type === GRID_BOOLEAN_COLUMN_TYPE;
+const isColBoolean = col.type === 'boolean';
  • Stop exporting the localization object before the merge with the core values.
- plPLGrid
- ruRUGrid
- skSKGrid
- ukUAGrid
- zhCNGrid

@flaviendelangle flaviendelangle self-assigned this Oct 6, 2021
@flaviendelangle flaviendelangle added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Oct 6, 2021
@flaviendelangle flaviendelangle marked this pull request as draft October 6, 2021 11:32
@flaviendelangle flaviendelangle marked this pull request as ready for review October 6, 2021 12:11
@flaviendelangle flaviendelangle added this to the v5 stable version milestone Oct 6, 2021
@flaviendelangle flaviendelangle merged commit ac70324 into mui:next Oct 13, 2021
@flaviendelangle flaviendelangle deleted the export-remove branch October 13, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant