-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Generate list of all exports #2801
Merged
flaviendelangle
merged 15 commits into
mui:next
from
flaviendelangle:generate-json-exports
Oct 28, 2021
Merged
[core] Generate list of all exports #2801
flaviendelangle
merged 15 commits into
mui:next
from
flaviendelangle:generate-json-exports
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
changed the title
[core] Generate list of all exports
[core] Generate list of all exports - WIP
Oct 7, 2021
flaviendelangle
changed the title
[core] Generate list of all exports - WIP
[core] Generate list of all exports
Oct 21, 2021
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 22, 2021
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 25, 2021
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 27, 2021
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Manually creating the list in #2227 (comment) was very time consuming but the result showed some problems like missing selector exports or unwanted exports.
My end goal would be to have a bot automatically displaying the list of the export added / removed on each PR.
Note that I only run the code on the
data-grid
package to avoid creating a new TypeDoc project fordata-grid-pro
since all thedocs:api:build
process is currently based ondata-grid
. I will benchmark the time it takes to run it on every package we publish.Result example if we run it on #2793
Result example if we run it on #2782