Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Stop using GridEvents enum in @mui/x-data-grid-premium #4685

Merged
merged 1 commit into from
Apr 29, 2022
Merged

[data grid] Stop using GridEvents enum in @mui/x-data-grid-premium #4685

merged 1 commit into from
Apr 29, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 28, 2022 •
edited
Loading

Part of #4684

This PR demonstrated what I want to do in #4684 but only on @mui/x-data-grid-premium to give a small example.
If you are ok with it, I can apply it to all our codebase.

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Apr 28, 2022
@flaviendelangle flaviendelangle self-assigned this Apr 28, 2022
@mui-bot
Copy link

mui-bot commented Apr 28, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 302.5 520.2 423.7 404.02 83.792
Sort 100k rows ms 493.2 920.9 893.5 784.5 162.463
Select 100k rows ms 133 285.9 199.9 206.48 49.373
Deselect 100k rows ms 159.6 279 184.7 203.32 41.464

Generated by 🚫 dangerJS against ca3238a

cherniavskii
cherniavskii approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree 👍

@flaviendelangle flaviendelangle changed the title [data grid] Stop using GridEvents enum [data grid] Stop using GridEvents enum in @mui/x-data-grid-premium Apr 28, 2022
DanailH
DanailH approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@DanailH DanailH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this as well.

@flaviendelangle flaviendelangle merged commit b0fbb8b into mui:master Apr 29, 2022
@flaviendelangle flaviendelangle deleted the grid-events-drop branch April 29, 2022 08:00
This was referenced Apr 29, 2022
Merged
Merged
@flaviendelangle flaviendelangle changed the title [data grid] Stop using GridEvents enum in @mui/x-data-grid-premium [data grid] Stop using GridEvents enum in @mui/x-data-grid-premium Apr 29, 2022
@flaviendelangle flaviendelangle mentioned this pull request Apr 29, 2022
Merged
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[data grid] Stop using GridEvents enum (mui#4685)
b8a2384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@DanailH DanailH DanailH approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @DanailH @cherniavskii