Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Generate the event documentation from GridEventLookup #4725

Merged
merged 3 commits into from
May 3, 2022
Merged

[docs] Generate the event documentation from GridEventLookup #4725

merged 3 commits into from
May 3, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 2, 2022 •
edited
Loading

Part of #4684

I moved detailPanelsExpandedRowIdsChange to the pro package
Otherwise it's just copy pasting the JSDoc and description from GridEvents to GridEventLookup and update the doc script.

@flaviendelangle flaviendelangle added the docs Improvements or additions to the documentation label May 2, 2022
@flaviendelangle flaviendelangle self-assigned this May 2, 2022
@flaviendelangle flaviendelangle changed the title [docs] Generate the event documentation from GridEventLookup [docs] Generate the event documentation from GridEventLookup May 2, 2022
@mui-bot
Copy link

mui-bot commented May 2, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 269.6 601.7 423 414.3 128.52
Sort 100k rows ms 444.3 1,209 444.3 899.02 252.926
Select 100k rows ms 186.3 262.6 209.6 224.34 30.632
Deselect 100k rows ms 122.8 362.1 275.9 241.66 97.929

Generated by 🚫 dangerJS against b6646a4

@github-actions
Copy link

github-actions bot commented May 2, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 3, 2022
@flaviendelangle flaviendelangle merged commit 3a552d3 into mui:master May 3, 2022
@flaviendelangle flaviendelangle deleted the event-doc-lookup branch May 3, 2022 08:10
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[docs] Generate the event documentation from GridEventLookup (mui#4725)
9e173c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @cherniavskii