-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Prettify the l10n issue #4928
Conversation
These are the results for the performance tests:
|
scripts/l10n.ts
Outdated
if (lineContent[lineContent.length - 1] === ',') { | ||
lineContent = lineContent.slice(0, lineContent.length - 1); | ||
} | ||
lines.push(` - [\`${lineContent}\`](${permalink})`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to escape ``. The line content may contain backstick when string interpolation is used, e.g. groupColumn
. Adding a space before closing seems to work. https://meta.stackexchange.com/a/138916
lines.push(` - [\`${lineContent}\`](${permalink})`); | |
lines.push(` - [\``${lineContent}\`](${permalink}) ``); // Add space before `` to escape ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I did not know about this space technic. Seems to work well ๐ฝ
๐บ๐ฆ uk-UA
๐งโ๐ผ DataGrid, DataGridPro, DataGridPremium(16 remaining)
-
toolbarQuickFilterPlaceholder: 'Search...'
-
toolbarQuickFilterLabel: 'Search'
-
toolbarQuickFilterDeleteIconLabel: 'Clear'
-
toolbarExportExcel: 'Download as Excel'
-
filterPanelLinkOperator: 'Logic operator'
-
filterOperatorIsAnyOf: 'is any of'
-
checkboxSelectionSelectAllRows: 'Select all rows'
-
checkboxSelectionUnselectAllRows: 'Unselect all rows'
-
checkboxSelectionSelectRow: 'Select row'
-
checkboxSelectionUnselectRow: 'Unselect row'
-
groupingColumnHeaderName: 'Group'
-
groupColumn: name => `Group by ${name}`
-
unGroupColumn: name => `Stop grouping by ${name}`
-
expandDetailPanel: 'Expand'
-
collapseDetailPanel: 'Collapse'
-
rowReorderingHeaderName: 'Row reordering'
๐ Date and Time Pickers: file to create
Add file
packages/x-date-pickers/src/locales/ukUA.ts
to start contribution to this locale
Co-authored-by: Matheus Wichman <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! You also need to update the introductory text, to remove "DataGrid...".
Lines 228 to 233 in eebcb69
const requestBody = `You can check below all of the localization files that contain at least one missing translation. If you are a fluent speaker of any of these languages, feel free to submit a pull request. Any help is welcome to make the X components to reach new cultures. | |
Run \`yarn l10n --report\` to update the list below โฌ๏ธ | |
## DataGrid / DataGridPro | |
${newMessage} |
Co-authored-by: Matheus Wichman <[email protected]>
Co-authored-by: Matheus Wichman <[email protected]>
Test with
details
component. Bellow the generated reportFirst part of #4914
Preview including
fr-FR
(the only other l10n for now)๐ซ๐ฎ fi-FI
๐งโ๐ผ DataGrid, DataGridPro, DataGridPremium(16 remaining)
toolbarQuickFilterPlaceholder: 'Search...'
toolbarQuickFilterLabel: 'Search'
toolbarQuickFilterDeleteIconLabel: 'Clear'
toolbarExportExcel: 'Download as Excel'
filterPanelLinkOperator: 'Logic operator'
filterOperatorIsAnyOf: 'is any of'
checkboxSelectionSelectAllRows: 'Select all rows'
checkboxSelectionUnselectAllRows: 'Unselect all rows'
checkboxSelectionSelectRow: 'Select row'
checkboxSelectionUnselectRow: 'Unselect row'
groupingColumnHeaderName: 'Group'
groupColumn: name => `Group by ${name}`
unGroupColumn: name =>
Stop grouping by ${name}``expandDetailPanel: 'Expand'
collapseDetailPanel: 'Collapse'
rowReorderingHeaderName: 'Row reordering'
๐ Date and Time Pickers: file to create
๐ซ๐ท fr-FR
๐งโ๐ผ DataGrid, DataGridPro, DataGridPremium(8 remaining)
toolbarExportExcel: 'Download as Excel'
checkboxSelectionSelectAllRows: 'Select all rows'
checkboxSelectionUnselectAllRows: 'Unselect all rows'
checkboxSelectionSelectRow: 'Select row'
checkboxSelectionUnselectRow: 'Unselect row'
expandDetailPanel: 'Expand'
collapseDetailPanel: 'Collapse'
rowReorderingHeaderName: 'Row reordering'
๐ Date and Time Pickers (Done โ )
๐ฎ๐ฑ he-IL
๐งโ๐ผ DataGrid, DataGridPro, DataGridPremium(6 remaining)
toolbarQuickFilterPlaceholder: 'Search...'
toolbarQuickFilterLabel: 'Search'
toolbarQuickFilterDeleteIconLabel: 'Clear'
toolbarExportExcel: 'Download as Excel'
filterPanelLinkOperator: 'Logic operator'
rowReorderingHeaderName: 'Row reordering'
๐ Date and Time Pickers: file to create