Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Prettify the l10n issue #4928

Merged
merged 10 commits into from
Jun 1, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented May 18, 2022

Test with details component. Bellow the generated report

First part of #4914

Preview including fr-FR (the only other l10n for now)

๐Ÿ‡ซ๐Ÿ‡ฎ fi-FI

๐Ÿง‘โ€๐Ÿ’ผ DataGrid, DataGridPro, DataGridPremium(16 remaining)
๐Ÿ•’ Date and Time Pickers: file to create

Add file packages/x-date-pickers/src/locales/fiFI.ts to start contribution to this locale

๐Ÿ‡ซ๐Ÿ‡ท fr-FR

๐Ÿง‘โ€๐Ÿ’ผ DataGrid, DataGridPro, DataGridPremium(8 remaining)
๐Ÿ•’ Date and Time Pickers (Done โœ…)

This locale has been completed by the community ๐Ÿš€
You can still look for typo fix or improvements in the translation file ๐Ÿ•ต

๐Ÿ‡ฎ๐Ÿ‡ฑ he-IL

๐Ÿง‘โ€๐Ÿ’ผ DataGrid, DataGridPro, DataGridPremium(6 remaining)
๐Ÿ•’ Date and Time Pickers: file to create

Add file packages/x-date-pickers/src/locales/heIL.ts to start contribution to this locale

@mui-bot
Copy link

mui-bot commented May 18, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean ฯƒ
Filter 100k rows ms 329.6 527.1 369.6 402.58 68.428
Sort 100k rows ms 522.6 1,071.7 737.9 835.52 189.136
Select 100k rows ms 156 215.1 189.9 190.3 21.887
Deselect 100k rows ms 101.6 267 200.1 193.74 54.751

Generated by ๐Ÿšซ dangerJS against 3ae514a

@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels May 19, 2022
scripts/l10n.ts Show resolved Hide resolved
scripts/l10n.ts Outdated Show resolved Hide resolved
scripts/l10n.ts Outdated Show resolved Hide resolved
scripts/l10n.ts Outdated
if (lineContent[lineContent.length - 1] === ',') {
lineContent = lineContent.slice(0, lineContent.length - 1);
}
lines.push(` - [\`${lineContent}\`](${permalink})`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to escape ``. The line content may contain backstick when string interpolation is used, e.g. groupColumn. Adding a space before closing seems to work. https://meta.stackexchange.com/a/138916

Suggested change
lines.push(` - [\`${lineContent}\`](${permalink})`);
lines.push(` - [\``${lineContent}\`](${permalink}) ``); // Add space before `` to escape `

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/l10n.ts Outdated Show resolved Hide resolved
scripts/l10n.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 27, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 1, 2022
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! You also need to update the introductory text, to remove "DataGrid...".

mui-x/scripts/l10n.ts

Lines 228 to 233 in eebcb69

const requestBody = `You can check below all of the localization files that contain at least one missing translation. If you are a fluent speaker of any of these languages, feel free to submit a pull request. Any help is welcome to make the X components to reach new cultures.
Run \`yarn l10n --report\` to update the list below โฌ‡๏ธ
## DataGrid / DataGridPro
${newMessage}

@alexfauquette alexfauquette merged commit 05119d9 into mui:master Jun 1, 2022
@alexfauquette alexfauquette deleted the prettify-l10n-report branch June 1, 2022 14:01
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants