[docs] Use new edit API in the introduction demos #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
|
These are the results for the performance tests:
|
|
Editing the Status column in https://deploy-preview-5728--material-ui-x.netlify.app/x/react-data-grid/demo/ is throwing an error because the API method changed and this is a custom edit component. I'll take care of this... |
|
@m4theushw Nice catch |
m4theushw
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
I pushed 5d7455c fixing the custom edit component.
A follow up may be to also use the new API in the demo in https://mui.com/x/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering how much we are burying the demo of the legacy editing API, and that the legacy API is buggy, e.g. with the Escape key:
Screen.Recording.2022-08-07.at.23.39.34.mov
https://mui.com/x/react-data-grid/#mit-version
I believe it would make more sense to demo it on the introduction demos. I believe these demos are used by developers to judge whether they will use or not the component.
One step in this direction #5606.
Preview: https://deploy-preview-5728--material-ui-x.netlify.app/x/introduction/