Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Remove GridEvents enum #6003

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 2, 2022

Closes #4684

Changelog

Breaking change

The GridEvents enum is now a TypeScript type.

-apiRef.current.subscribeEvent(GridEvents.rowClick', handleRowClick)
+apiRef.current.subscribeEvent('rowClick', handleRowClick)

@flaviendelangle flaviendelangle added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Sep 2, 2022
@flaviendelangle flaviendelangle self-assigned this Sep 2, 2022
@mui-bot
Copy link

mui-bot commented Sep 2, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 508.4 1,061.8 508.4 748.46 234.883
Sort 100k rows ms 555.3 1,203.2 555.3 898.76 234.906
Select 100k rows ms 213.7 321.4 235.6 254.94 38.382
Deselect 100k rows ms 119.9 309.5 199 215.62 78.158

Generated by 🚫 dangerJS against 7cae5d9

@flaviendelangle flaviendelangle marked this pull request as ready for review September 5, 2022 08:29
@DanailH
Copy link
Member

DanailH commented Sep 6, 2022

I've no objections to this change. If we are doing this then it probably makes sense to also remove, as part of a separate PR (I can take care of it), the GridFeatureModeConstant and just keep the type.

Also, we can point this to next on Friday and merge it.

@flaviendelangle
Copy link
Member Author

I've no objections to this change. If we are doing this then it probably makes sense to also remove, as part of a separate PR (I can take care of it), the GridFeatureModeConstant and just keep the type.

Indeed this fake enum make no sense to me 😆

@flaviendelangle flaviendelangle changed the base branch from master to next September 9, 2022 09:35
@flaviendelangle
Copy link
Member Author

@DanailH if you can approve this one

@flaviendelangle flaviendelangle merged commit 2028bd6 into mui:next Sep 12, 2022
@flaviendelangle flaviendelangle deleted the remove-grid-events-enum branch September 12, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Remove GridEvents enum
3 participants