Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Unify RFC template using core version #6100

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[core] Unify RFC template using core version #6100

merged 1 commit into from
Sep 9, 2022

Conversation

bytasv
Copy link
Contributor

@bytasv bytasv commented Sep 9, 2022

Update template as per mui/material-ui#33871 discussion

@bytasv bytasv requested a review from a team September 9, 2022 10:52
@bytasv bytasv self-assigned this Sep 9, 2022
@bytasv bytasv changed the base branch from next to master September 9, 2022 10:54
@bytasv bytasv added the core Infrastructure work going on behind the scenes label Sep 9, 2022
@mui-bot
Copy link

mui-bot commented Sep 9, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 491.1 918.1 656.5 682.18 157.52
Sort 100k rows ms 556.2 1,092.1 556.2 901.36 198.664
Select 100k rows ms 218.5 310.9 267.8 262.48 32.441
Deselect 100k rows ms 133.6 280.8 179.3 185.72 52.822

Generated by 🚫 dangerJS against 70aefa9

@bytasv bytasv merged commit 9043708 into mui:master Sep 9, 2022
@bytasv bytasv deleted the update-rfc-template branch September 9, 2022 11:33
oliviertassinari pushed a commit to oliviertassinari/mui-x that referenced this pull request Sep 9, 2022
@bytasv @oliviertassinari
Update rfc template (mui#6100)
a70c206 
Unify RFC template using core version
@flaviendelangle
Copy link
Member

@bytasv avoid merging in master, we moved to the next branch
I'll rebase 👍

@LukasTy
Copy link
Member

LukasTy commented Sep 12, 2022

@flaviendelangle Is there a problem merging github issue template into master for immediate usage? 🤔

@flaviendelangle
Copy link
Member

Since our default branch is next, doesn't Github use this one for the templates ?

@flaviendelangle
Copy link
Member

We seem to have the old one : https://github.com/mui/mui-x/issues/new?assignees=&labels=RFC&template=5.rfc.yml&title=%5BRFC%5D+

@LukasTy
Copy link
Member

LukasTy commented Sep 12, 2022

🤦‍♂️ Good point 👍

@bytasv
Copy link
Contributor Author

bytasv commented Sep 12, 2022

Thanks for info! I'll be more careful next time 🙇

alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Sep 12, 2022
@bytasv @alexfauquette
Update rfc template (mui#6100)
e165de6 
Unify RFC template using core version
@oliviertassinari oliviertassinari changed the title Update rfc template [core] Unify RFC template using core version Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees

@bytasv bytasv

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bytasv @mui-bot @flaviendelangle @LukasTy