Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Rename filterPanelOperators -> filterPanelOperator #7062

Merged
merged 3 commits into from
Dec 2, 2022
Merged

[DataGrid] Rename filterPanelOperators -> filterPanelOperator #7062

merged 3 commits into from
Dec 2, 2022

Conversation

MBilalShafi
Copy link
Member

Fixes #6963

Changelog

Breaking changes

  • filterPanelOperators translation key was renamed to filterPanelOperator

@MBilalShafi MBilalShafi self-assigned this Dec 2, 2022
@MBilalShafi MBilalShafi changed the title Rename filterPanelOperators -> filterPanelOperator [DataGrid] Rename filterPanelOperators -> filterPanelOperator Dec 2, 2022
@mui-bot
Copy link

mui-bot commented Dec 2, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7062--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 635.3 1,213.8 635.3 874.06 251.627
Sort 100k rows ms 594.6 1,135.1 594.6 896.44 187.288
Select 100k rows ms 227.8 318.3 280.9 282.1 32.14
Deselect 100k rows ms 156.5 304.5 189.5 208.9 51.191

Generated by 🚫 dangerJS against 56b3f2f

@MBilalShafi MBilalShafi mentioned this pull request Dec 2, 2022
Merged
alexfauquette
alexfauquette approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the kind of breaking change that could worth a codemod

@MBilalShafi MBilalShafi added the codemod candidate Suitable for writing a codemod for label Dec 2, 2022
@MBilalShafi @m4theushw
Apply suggestions from code review
56b3f2f 
Co-authored-by: Matheus Wichman <[email protected]>
Signed-off-by: Bilal Shafi <[email protected]>
@MBilalShafi MBilalShafi merged commit d8b76d3 into mui:next Dec 2, 2022
@MBilalShafi MBilalShafi deleted the fixes-6963 branch December 2, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@m4theushw m4theushw m4theushw approved these changes

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@MBilalShafi MBilalShafi

Labels
breaking change codemod candidate Suitable for writing a codemod for l10n localization v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Rename the filterPanelOperators translation key filterPanelOperator
4 participants
@MBilalShafi @mui-bot @m4theushw @alexfauquette