Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove internals-fields imports #7119

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[core] Remove internals-fields imports #7119

merged 1 commit into from
Dec 7, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Dec 7, 2022 •
edited
Loading

I created this endpoint to avoid importing date-fns on @mui/x-date-pickers, but now that the field use the adapters, we don't need this endpoint anymore.

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: pickers This is the name of the generic UI component, not the React module! labels Dec 7, 2022
@flaviendelangle flaviendelangle self-assigned this Dec 7, 2022
@flaviendelangle flaviendelangle marked this pull request as ready for review December 7, 2022 09:13
@mui-bot
Copy link

mui-bot commented Dec 7, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-7119--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 655.1 1,180.4 655.1 905.6 180.439
Sort 100k rows ms 681.6 1,253 1,253 1,027.98 207.096
Select 100k rows ms 243.5 331.2 311.4 295.46 30.78
Deselect 100k rows ms 152 291.4 190.9 213.62 58.901

Generated by 🚫 dangerJS against 1992b84

alexfauquette
alexfauquette approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively, it's not needed anymore 👍

@flaviendelangle flaviendelangle merged commit 7ab4bbd into mui:next Dec 7, 2022
@flaviendelangle flaviendelangle deleted the internals-field branch December 7, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @alexfauquette