[DataGrid] Remove rowHeight and headerHeight from state
#7199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
breaking change
component: data grid
DanailH
requested review from
MBilalShafi,
cherniavskii,
m4theushw and
alexfauquette
DanailH
commented
Dec 14, 2022
These are the results for the performance tests:
|
packages/grid/x-data-grid/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx
Show resolved
Hide resolved
packages/grid/x-data-grid-premium/src/components/GridAggregationHeader.tsx
Show resolved
Hide resolved
packages/grid/x-data-grid/src/hooks/features/density/useGridDensity.tsx
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid/src/hooks/features/dimensions/useGridDimensions.ts
Outdated
Show resolved
Hide resolved
| apiRef: React.MutableRefObject<GridApiCommunity>, | ||
| rowHeight: number, | ||
| ) { | ||
| const densityFactor = gridDensityFactorSelector(apiRef); |
There was a problem hiding this comment.
Consider passing densityFactor instead of apiRef?
Same as #7199 (comment)
packages/grid/x-data-grid/src/hooks/features/rows/useGridRowsMeta.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…nsity.tsx Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
…nsity.tsx Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
approved these changes
Dec 23, 2022
docs/data/migration/migration-data-grid-v5/migration-data-grid-v5.md
Outdated
Show resolved
Hide resolved
…-v5.md Co-authored-by: Andrew Cherniavskii <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5620