Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove the columnTypes prop #7309

Merged
merged 2 commits into from
Jan 6, 2023
Merged

[DataGrid] Remove the columnTypes prop #7309

merged 2 commits into from
Jan 6, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Dec 23, 2022 •
edited by MBilalShafi
Loading

Closes #242

Changelog

Breaking changes

@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Dec 23, 2022
@mui-bot
Copy link

mui-bot commented Dec 23, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-7309--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 629.6 1,106.9 629.6 837.4 189.244
Sort 100k rows ms 616 1,010.2 850 852.22 132.315
Select 100k rows ms 205 279.3 232.5 233.14 26.89
Deselect 100k rows ms 150.2 280.2 183.8 200.12 49.774

Generated by 🚫 dangerJS against 8dc65c0

@cherniavskii cherniavskii marked this pull request as ready for review December 23, 2022 19:03
@cherniavskii cherniavskii merged commit 4610080 into mui:next Jan 6, 2023
@cherniavskii cherniavskii deleted the remove-columnTypes branch January 6, 2023 14:25
@MBilalShafi MBilalShafi mentioned this pull request Jan 12, 2023
Closed
16 tasks
@oliviertassinari oliviertassinari mentioned this pull request Jul 21, 2023
Closed
@oliviertassinari oliviertassinari mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@DanailH DanailH DanailH approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Remove the columnTypes prop
4 participants
@cherniavskii @mui-bot @DanailH @m4theushw