Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Rename linkOperators to logicOperators #7310

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Dec 23, 2022

Closes #7270

I took the opportunity for the breaking changes and renamed linkOperator to logicOperator in other props or CSS classes for consistency.

Changelog

Breaking changes

  • The apiRef.current.setFilterLinkOperator method was renamed to apiRef.current.setFilterLogicOperator.
  • The GridLinkOperator enum was renamed to GridLogicOperator.
  • The GridFilterModel['linkOperator'] was renamed to GridFilterModel['logicOperator'].
  • The linkOperators prop of GridFilterForm and GridFilterPanel components was renamed to logicOperators.
  • The linkOperatorInputProps prop of GridFilterForm component was renamed to logicOperatorInputProps.
  • The filterFormProps.linkOperatorInputProps prop in GridFilterForm component was renamed to filterFormProps.logicOperatorInputProps.
  • The GridLocaleText['filterPanelLinkOperator'] property was renamed to GridLocaleText['filterPanelLogicOperator'].
  • The .MuiDataGrid-filterFormLinkOperatorInputCSS class was renamed to .MuiDataGrid-filterFormLogicOperatorInput.

@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Dec 23, 2022
@mui-bot
Copy link

mui-bot commented Dec 23, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-7310--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 629.8 1,192.9 629.8 869.82 231.337
Sort 100k rows ms 697.9 1,321 1,321 1,009 210.489
Select 100k rows ms 215.3 401.3 280.9 290.26 68.965
Deselect 100k rows ms 202.7 370.9 257.4 264.32 60.534

Generated by 🚫 dangerJS against fee6b54

@cherniavskii cherniavskii marked this pull request as ready for review December 23, 2022 21:40
@m4theushw m4theushw changed the title [DataGrid] Rename linkOperator [DataGrid] Rename linkOperators to logicOperators Jan 5, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 5, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2023
@cherniavskii cherniavskii merged commit 8f93c09 into mui:next Jan 12, 2023
@cherniavskii cherniavskii deleted the logicOperator branch January 12, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename GridFilterModel['linkOperator'] to GridFilterModel['logicOperator'] and same for translations
4 participants