Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove disableExtendRowFullWidth prop #7373

Merged
merged 8 commits into from
Jan 13, 2023
Merged

[DataGrid] Remove disableExtendRowFullWidth prop #7373

merged 8 commits into from
Jan 13, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Jan 2, 2023 •
edited
Loading

Fixes #4308

Preview: https://deploy-preview-7373--material-ui-x.netlify.app/x/react-data-grid/column-spanning/#number-signature

Changelog

Breaking changes

  • The prop disableExtendRowFullWidth was removed.

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x labels Jan 2, 2023
@mui-bot
Copy link

mui-bot commented Jan 2, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7373--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 625.1 987.6 707.1 765.08 128.036
Sort 100k rows ms 607.5 1,114.1 852.6 887.26 165.363
Select 100k rows ms 202.3 294 219.2 230.58 32.507
Deselect 100k rows ms 152.1 265.5 196.5 205.74 37.745

Generated by 🚫 dangerJS against 8171bb0

MBilalShafi
MBilalShafi commented Jan 11, 2023
View reviewed changes
packages/grid/x-data-grid/src/components/columnHeaders/GridColumnGroupHeader.tsx
@@ -46,8 +43,8 @@ const useUtilityClasses = (ownerState: OwnerState) => {
headerAlign === 'center' && 'columnHeader--alignCenter',
headerAlign === 'right' && 'columnHeader--alignRight',
isDragging && 'columnHeader--moving',
showRightBorder && 'columnHeader--withRightBorder',
showColumnBorder && 'columnHeader--showColumnBorder',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't combine these two as they apparently serve different purposes and might be segregated again in future

@MBilalShafi
Copy link
Member Author

MBilalShafi commented Jan 11, 2023 •
edited
Loading

Updated default behavior: Right border for the last column will now be shown based on showCellVerticalBorder and showHeaderVerticalBorder same as other columns. (see argos difference)

@MBilalShafi MBilalShafi marked this pull request as ready for review January 11, 2023 15:21
m4theushw
m4theushw approved these changes Jan 12, 2023
View reviewed changes
docs/data/data-grid/column-spanning/ColumnSpanningFunction.tsx
@@ -126,7 +126,6 @@ export default function ColumnSpanningFunction() {
>
<DataGrid
autoHeight
disableExtendRowFullWidth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this demo has not leveraged disableExtendRowFullWidth to remove the double border in the last column:

image

Anyway, I think we could invest time later and remove the border of the last column if there's no empty space left. Even after adding flex: 1 in a column, this double border will be there.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 13, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 13, 2023
@MBilalShafi MBilalShafi mentioned this pull request Jan 13, 2023
Merged
2 tasks
@MBilalShafi MBilalShafi mentioned this pull request Jan 13, 2023
Closed
16 tasks
@MBilalShafi MBilalShafi self-assigned this Jan 13, 2023
@MBilalShafi MBilalShafi merged commit 2dcaba2 into mui:next Jan 13, 2023
@MBilalShafi MBilalShafi deleted the remove-disableExtendRowFullWidth-prop branch January 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw m4theushw approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Remove disableExtendRowFullWidth prop
3 participants
@MBilalShafi @mui-bot @m4theushw