Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove legacy logic for singleSelect inside GridFilterInputValue #7386

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[DataGrid] Remove legacy logic for singleSelect inside GridFilterInputValue #7386

merged 1 commit into from
Jan 5, 2023

Conversation

m4theushw
Copy link
Member

Closes #7271

@m4theushw m4theushw added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Jan 4, 2023
@mui-bot
Copy link

mui-bot commented Jan 4, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7386--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 620.6 902 774 763.8 123.429
Sort 100k rows ms 608.1 1,135.9 772.2 869.68 175.096
Select 100k rows ms 163.8 281.9 257.8 238.82 43.894
Deselect 100k rows ms 139.1 289.1 188.4 205.8 59.901

Generated by 🚫 dangerJS against 91f37f0

@m4theushw m4theushw force-pushed the legacy-single-select-logic branch from 2e016b1 to 91f37f0 Compare January 4, 2023 14:27
@m4theushw m4theushw requested a review from MBilalShafi January 4, 2023 23:42
@m4theushw m4theushw merged commit 1f244b9 into mui:next Jan 5, 2023
@m4theushw m4theushw deleted the legacy-single-select-logic branch January 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the single select logic still present in GridFilterInputValue
3 participants
@m4theushw @mui-bot @flaviendelangle