Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Use v6 terminology #7473

Merged
merged 6 commits into from
Jan 16, 2023
Merged

[DataGrid] Use v6 terminology #7473

merged 6 commits into from
Jan 16, 2023

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Jan 11, 2023

Based on #4151

Breaking changes

  • The gridVisibleSortedRowIdsSelector selector was renamed to gridExpandedSortedRowIdsSelector
  • The gridVisibleSortedRowEntriesSelector selector was renamed to gridExpandedSortedRowEntriesSelector
  • The gridVisibleRowCountSelector selector was renamed to gridExpandedRowCountSelector
  • The apiRef.current.getVisibleRowModels method was removed. Use the gridVisibleSortedRowEntriesSelector selector instead
  • The gridVisibleSortedTopLevelRowEntriesSelector selector was renamed to gridFilteredSortedTopLevelRowEntriesSelector
  • The gridVisibleTopLevelRowCountSelector selector was renamed to gridFilteredTopLevelRowCountSelector
  • The GridRowScrollEndParams["virtualRowsCount"] param was renamed to GridRowScrollEndParams["visibleRowsCount"]

@DanailH DanailH added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Jan 11, 2023
@DanailH DanailH self-assigned this Jan 11, 2023
@mui-bot
Copy link

mui-bot commented Jan 11, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7473--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 640.1 1,230.6 640.1 880.92 222.699
Sort 100k rows ms 720.4 1,292 1,292 1,041.3 194.346
Select 100k rows ms 229.5 333.2 281.8 282.4 38.11
Deselect 100k rows ms 162 459 211.5 266.8 106.77

Generated by 🚫 dangerJS against 638ad6d

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 12, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 12, 2023
@MBilalShafi MBilalShafi added the codemod candidate Suitable for writing a codemod for label Jan 16, 2023
@DanailH DanailH merged commit 26a537d into mui:next Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees

@DanailH DanailH

Labels
breaking change codemod candidate Suitable for writing a codemod for component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanailH @mui-bot @MBilalShafi