Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update custom field pickers using theme scoping #8609

Merged
merged 10 commits into from
Apr 26, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 13, 2023

With theme scoping, using Material UI and Joy UI together is simple. The version needs 5.12.0.

DataGrid integration with Joy UI would benefit from this PR as well.

@siriwatknp siriwatknp changed the title [docs] Update custom field pickers using Joy UI [docs] Update custom field pickers using theme scoping Apr 13, 2023
@mui-bot
Copy link

mui-bot commented Apr 13, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8609--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 736.8 1,270 736.8 940.1 215.653
Sort 100k rows ms 846.5 1,205.1 1,191.4 1,085.46 131.325
Select 100k rows ms 266.3 476.7 293.8 339.34 78.049
Deselect 100k rows ms 150.9 276.6 216.1 214.2 50.026

Generated by 🚫 dangerJS against 373833d

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Apr 13, 2023
@flaviendelangle
Copy link
Member

@siriwatknp I fixed the CI, except for the regressions test which seems to be an actual issue when running PickerWithJoyField inside the regression tests :/

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 20, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 20, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 20, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 20, 2023
@siriwatknp siriwatknp merged commit e5f42a0 into mui:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants