Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Allow overflowing grid root element #9179

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented May 31, 2023

Fixes #8547 (comment)

I have no idea why the visual regressions were not reported in #8577

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse feature: Rendering layout Related to the data grid Rendering engine labels May 31, 2023
@mui-bot
Copy link

mui-bot commented May 31, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9179--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 632.3 1,096.3 634.3 815.08 172.707
Sort 100k rows ms 515 1,160.4 644.9 840.68 231.328
Select 100k rows ms 169.1 289.7 220.6 228.46 49.207
Deselect 100k rows ms 160.4 377.4 266.9 272.98 81.163

Generated by 🚫 dangerJS against c0c6c04

@cherniavskii cherniavskii marked this pull request as ready for review June 5, 2023 10:10
@cherniavskii cherniavskii merged commit f69cd08 into mui:master Jun 5, 2023
@cherniavskii cherniavskii deleted the fix-grid-overflow-hidden branch June 5, 2023 18:39
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] v5 worked fine inside "display: 'grid'" but v6 doesn't work properly
4 participants