[core] Update babel configs #9244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
commented
Jun 6, 2023
Comment on lines
-58
to
-59
| // TODO fix useGridSelector side effect and enable back. | ||
| // '@babel/plugin-transform-react-constant-elements', |
There was a problem hiding this comment.
@oliviertassinari I've uncommented this one to see if we can cleanup, not sure what's the side-effect though.
Linked: #666
There was a problem hiding this comment.
I have updated the PR (#666) to better describe the issue.
romgrk
commented
Jun 6, 2023
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9244--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
romgrk
commented
Jun 6, 2023
Comment on lines
-26
to
-27
| // backport of https://github.com/zeit/next.js/pull/9511 | ||
| ['next/babel', { 'transform-runtime': { corejs: 2, version: transformRuntimeVersion } }], |
There was a problem hiding this comment.
Latest corejs version is 3 and this is 4 years old, I think we can use the default version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the babel configs, and share as much as possible between the root & docs configs.
Linked: mui/material-ui#37461