Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Skip flaky row pinning tests in JSDOM #9511

Merged
merged 2 commits into from
Jun 29, 2023
Merged

[test] Skip flaky row pinning tests in JSDOM #9511

merged 2 commits into from
Jun 29, 2023

Conversation

cherniavskii
Copy link
Member

I don't know why these tests often fail in JSDOM, and I don't want to waste more time investigating it.
Running these tests in the browser should be enough.

@cherniavskii cherniavskii added test component: data grid This is the name of the generic UI component, not the React module! labels Jun 28, 2023
@cherniavskii cherniavskii mentioned this pull request Jun 28, 2023
Merged
@mui-bot
Copy link

mui-bot commented Jun 28, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9511--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 468.8 1,086.7 661.1 800.56 213.787
Sort 100k rows ms 528.7 1,095.9 881.1 899.06 197.266
Select 100k rows ms 165.8 427.4 242.2 284.02 91.117
Deselect 100k rows ms 206.9 275.4 213.2 224.7 25.58

Generated by 🚫 dangerJS against ba58dd1

LukasTy
LukasTy approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, these two are becoming an insane annoyance and money-pits, because CI re-runs have to be triggered 🤦

alexfauquette
alexfauquette approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@cherniavskii cherniavskii merged commit 889af42 into mui:master Jun 29, 2023
@cherniavskii cherniavskii deleted the skip-flaky-tests-in-jsdom branch June 29, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherniavskii @mui-bot @LukasTy @alexfauquette