Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix API page regression: bring back slots section #9866

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Aug 1, 2023

Fixes #9857

@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Aug 1, 2023
@mui-bot
Copy link

mui-bot commented Aug 1, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9866--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 318.7 490.6 423.1 406.14 72.539
Sort 100k rows ms 481.2 898.4 827.9 737.48 167.675
Select 100k rows ms 181.2 220.5 198.3 199.12 12.609
Deselect 100k rows ms 108.4 258.8 214.9 190.18 58.851

Generated by 🚫 dangerJS against 971d042

@LukasTy
Copy link
Member

LukasTy commented Aug 1, 2023

I'm not sure if the current form of providing the default is clear in any way... 🤔
IMHO, I would struggle to understand what that grey text means... 🤷
Secondly, I'm pretty sure that none of the slots are required. 🤔
Screenshot 2023-08-01 at 13 14 53

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 1, 2023
@alexfauquette
Copy link
Member Author

For the Required it will be fixed by mui/material-ui#38183

About removing the description, it might interfere with the docs of other packages (joy also has a class name section). I keep it as it is for now, since bigger modification might impact that aspect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] DataGrid slots seem to be missing
5 participants