This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
Rework using webapi-parser #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limitation: Only top-level response body example values are
now sanitized.
E.g. if response body is specified as
type: object
properties:
age: number
example:
age: 67
example will be sanitized to {"age": 67}
On the other hand, if response body is nested like so
type: object
properties:
nested:
type: object
properties:
age: number
example:
nested:
age: 67
it won't be sanitize and response body will be {"nested": {"age": "67"}}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes (BREAKING):
webapi-parserobjects instead of JS Objects/JSON;Minor changes:
const/letinstead ofvar;Making a release:
PR depends on:
Performance:
Performance changes are described (and can be updated) in the osprey-profiling repo.
To test the PR locally with all the reworked Osprey sub-dependencies, use this Makefile.