-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: change Service.delete
to borrow rather than consume self
#90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense esp. because deletion can fail so it makes no sense to consume the Service
. I am not sure there was any need to go through all examples and change println!
but I'll leave it up to someone else to review. I am still using println!
in the old ways and not very used to {variable}
.
Reviewable status: complete! all files reviewed, all discussions resolved
Those |
This one can wait for #89 to make use of that error helper function in the example. |
Just rebased it. Should be ready to merge. |
We had a call to |
@citreae535 previous PRs are already merged so you could perhaps rebase this one and see my other comment above too. |
The uninstall example now polls for service stop and deletion with a timeout. |
Merged. Good work & thanks for contributions! 👍 |
The underlying win32 API call merely marks the service for deletion. It can be called even if the service is not stopped and will not invalidate the caller's open handle to it. Making the function not consuming self allows the caller to decide when to close the handle. Docs and examples are updated to show the correct behavior of this API.
This change is