Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding urls with http/https #28

Closed
cpacia opened this issue Jun 11, 2016 · 4 comments
Closed

Encoding urls with http/https #28

cpacia opened this issue Jun 11, 2016 · 4 comments

Comments

@cpacia
Copy link

cpacia commented Jun 11, 2016

I don't know if I'm missing something but is there a way to use the http/https codes to encode a url?
ex) dropbox.com/asdf/

I can use the AddProtocol function but it can't parse added protocols with a non zero length.

I'm able to hack around it but using /ipfs/<encoded url>/https/ but that seems a bit ugly.

@RichardLitt
Copy link
Member

@whyrusleeping?

@jbenet
Copy link
Member

jbenet commented Jun 16, 2016

Yeah we want to be able to encode http in multiaddr. We had some work on websocket addresses, @whyrusleeping can you point to it here?

We can do http addrs like:

  • simple paths (no query string) just get appended: .../http/foo.com/baz/quuz
  • paths with complicated strings, and query strings with params with slashes will have to get encoded: .../http_/cb123c4cb1234c3b124cb1234cb123 (suppose that's hex)

@ghost ghost self-assigned this Nov 2, 2016
@victorb
Copy link
Member

victorb commented Apr 18, 2018

We should have a discussion about defining /http as a whole over here: multiformats/multiaddr#63

@victorb victorb closed this as completed Apr 18, 2018
@bobheadxi
Copy link

bobheadxi commented Jan 14, 2019

@cpacia you seem to imply this was working:

I'm able to hack around it but using /ipfs//https/ but that seems a bit ugly.

since there has been no activity on multiformats/multiaddr#63, i was wondering if you could explain what you meant? specifically, I'm trying to use ipfs swarm connect to a node whose connection is routed through a server (ie 127.0.0.1/network/swarm)

if anyone else could provide any pointers it would be much appreciated as well!

marten-seemann pushed a commit to marten-seemann/go-multiaddr that referenced this issue Feb 25, 2021
marten-seemann pushed a commit to marten-seemann/go-multiaddr that referenced this issue Feb 25, 2021
…actions

Consolidate abstractions and core types into go-libp2p-core (multiformats#28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants