add Transocoder functionality #42
Conversation
Allowing multiaddr extensions to have data with
|
What is the goal of this PR, and how does it achieve it? Can't review 370 changed lines with only half a sentence of description ;) |
|
166*2 lines of the is just code moved Rest (50) is Transcoder interface that allows to have data in multiaddr without having your Protocol encoding and decoding inside this repo. |
|
Could you split the refactoring and added functionality into two commits? |
|
No, it isn't possible as then commit won't build and/or pass tests. |
|
//cc @whyrusleeping, @lgierth for CR |
| BytesToString([]byte) (string, error) | ||
| } | ||
|
|
||
| type twrp struct { |
There was a problem hiding this comment.
maybe provide a function that constructs one of these given two functions?
|
Updated. |
|
@whyrusleeping CR pls. |
|
i wish git diffs were smarter. All youre really doing here is moving code around, but git thinks youre rewriting EVERYTHING. This LGTM, but would love @lgierth to also take a look. |
|
LGTM 👍 It'll also simplify potentially adding multiaddr protocols with more than one value. |
|
@Kubuxu coverage decreased. I'm very disapointed. (though this LGTM and i'm gonna merge it) |
Add "ip6%" multiaddr support (IPv6 with zone ID)
…github.com/onsi/gomega-1.9.0 Bump github.com/onsi/gomega from 1.8.1 to 1.9.0
Allowing multiaddr extensions to have data with