Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed websocket [secure] to endpoint selection. #90

Closed

Conversation

Jorropo
Copy link

@Jorropo Jorropo commented Jul 10, 2019

This is for be compatible with libp2p/go-ws-transport#48 to allow websocket secure to be served under a real website (with reverse proxy) to go-libp2p.

To do:

@lidel
Copy link
Member

lidel commented Aug 20, 2019

I believe this is an example of generic need to specify/ovierride protocol-specific parameters. We discussed this recently from /http perspective (want to allow custom Host and path for use in DNS-over-HTTPS).

No consensus yet, but short summary/follow-up will be posted in multiformats/multiaddr#63 (comment)

@Jorropo Jorropo closed this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants