This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
Use aegir #9
Merged
Use aegir #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "test:browser": "./node_modules/.bin/zuul --browser-version $BROWSER_VERSION --browser-name $BROWSER_NAME -- tests/test.js", | ||
| "test:node": "aegir-test node", | ||
| "lint": "aegir-lint", | ||
| "test:browser": "aegir-test browser", | ||
| "test:browser:q": "BROWSER_VERSION=46 BROWSER_NAME=chrome npm run test:browser", |
|
Thank you @nginnever . Made some comments :) |
|
Thanks for the CR @diasdavid updates made |
|
|
||
| The code published to npm that gets loaded on require is in fact a ES5 transpiled version with the right shims added. This means that you can require it and use with your favourite bundler without having to adjust asset management process. | ||
|
|
||
| ```var multihash = require('js-multihash') |
There was a problem hiding this comment.
needs to change to
var multihash = require('js-multihash')
There was a problem hiding this comment.
actually the npm package is called multihashes as written above.
There was a problem hiding this comment.
that's write. I just had noticed how the triple ` were not rendering correctly
|
made one more comment and wanted to ask, since you are at it, could you update the david-dm badge url to: https://david-dm.org/jbenet/js-multihash ? Thank you :) |
|
and done :D |
|
wowowo thank you! :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref ipfs/aegir#1