Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain dnsaddr suffix matching #103

Merged
merged 2 commits into from
Nov 12, 2019
Merged

docs: explain dnsaddr suffix matching #103

merged 2 commits into from
Nov 12, 2019

Conversation

olizilla
Copy link
Contributor

include info on:

  • dnsaddr suffix matching
  • caveat about max udp dns response size

see: #102

License: MIT
Signed-off-by: Oli Evans [email protected]

includes
- dnsaddr suffix matching
- caveat about max udp dns response size

see: #102

License: MIT
Signed-off-by: Oli Evans <[email protected]>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with small tweaks below

protocols/DNSADDR.md Outdated Show resolved Hide resolved
protocols/DNSADDR.md Outdated Show resolved Hide resolved
protocols/DNSADDR.md Outdated Show resolved Hide resolved
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I'm so glad this is all being documented!

protocols/DNSADDR.md Outdated Show resolved Hide resolved
thanks @lidel & @alanshaw !

Co-Authored-By: Marcin Rataj <[email protected]>
Co-Authored-By: Alan Shaw <[email protected]>
@Stebalien
Copy link
Member

Awesome!

@olizilla olizilla merged commit 32440f3 into master Nov 12, 2019
@olizilla olizilla deleted the doc-dnsaddr-suffix branch November 12, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants