FIX(client): Only allow "http" and "https" schemes in ConnectDialog for web page #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
requested changes
Feb 6, 2021
Krzmbrzl
force-pushed
the
connectdialog-url-scheme-filter
branch
from
e03d947
to
c745397
Compare
Krzmbrzl
approved these changes
Feb 6, 2021
Krzmbrzl
reviewed
Feb 6, 2021
Our public server list registration script doesn't have an URL scheme whitelist for the website field. Turns out a malicious server can register itself with a dangerous URL in an attempt to attack a user's machine. User interaction is required, as the URL has to be opened by right-clicking on the server entry and clicking on "Open Webpage". This commit introduces a client-side whitelist, which only allows "http" and "https" schemes. We will also implement it in our public list. In future we should probably add a warning QMessageBox informing the user that there's no guarantee the URL is safe (regardless of the scheme). Thanks a lot to https://positive.security for reporting the RCE vulnerability to us privately.
Scanning directory './src'...
Scanning directory './src/mumble'...
Updating 'src/mumble/mumble_en.ts'...
Found 1929 source text(s) (3 new and 1926 already existing)
Krzmbrzl
force-pushed
the
connectdialog-url-scheme-filter
branch
from
c745397
to
0364272
Compare
Krzmbrzl
added a commit
that referenced
this pull request
Feb 6, 2021
…ttps" for URLs in ConnectDialog" Our public server list registration script doesn't have an URL scheme whitelist for the website field. Turns out a malicious server can register itself with a dangerous URL in an attempt to attack a user's machine. User interaction is required, as the URL has to be opened by right-clicking on the server entry and clicking on "Open Webpage". This commit introduces a client-side whitelist, which only allows "http" and "https" schemes. We will also implement it in our public list. In future we should probably add a warning QMessageBox informing the user that there's no guarantee the URL is safe (regardless of the scheme). Thanks a lot to https://positive.security for reporting the RCE vulnerability to us privately. This is a backport of #4733
davidebeatrici
commented
Feb 6, 2021
10 tasks
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
Mar 28, 2021
The previous dialog was simply a message box with a bunch of HTML in order to give a little structure to the contents. This approach is very limiting in terms of UI flexibility though and therefore this commit replaces the old HTML approach with a dedicated dialog class that uses proper UI elements instead. While doing so, the ordering and grouping of information was also changed in order to make it more suitable for the every-day-user. Fixes mumble-voip#4733
1 task
Krzmbrzl
added a commit
to Krzmbrzl/mumble
that referenced
this pull request
Mar 28, 2021
The previous dialog was simply a message box with a bunch of HTML in order to give a little structure to the contents. This approach is very limiting in terms of UI flexibility though and therefore this commit replaces the old HTML approach with a dedicated dialog class that uses proper UI elements instead. While doing so, the ordering and grouping of information was also changed in order to make it more suitable for the every-day-user. Fixes mumble-voip#4733
Krzmbrzl
added a commit
that referenced
this pull request
Mar 28, 2021
…on dialog The previous dialog was simply a message box with a bunch of HTML in order to give a little structure to the contents. This approach is very limiting in terms of UI flexibility though and therefore this commit replaces the old HTML approach with a dedicated dialog class that uses proper UI elements instead. While doing so, the ordering and grouping of information was also changed in order to make it more suitable for the every-day-user. Fixes #4733
frelon
pushed a commit
to frelon/mumble
that referenced
this pull request
May 3, 2021
The previous dialog was simply a message box with a bunch of HTML in order to give a little structure to the contents. This approach is very limiting in terms of UI flexibility though and therefore this commit replaces the old HTML approach with a dedicated dialog class that uses proper UI elements instead. While doing so, the ordering and grouping of information was also changed in order to make it more suitable for the every-day-user. Fixes mumble-voip#4733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our public server list registration script doesn't have an URL scheme whitelist for the website field.
Turns out a malicious server can register itself with a dangerous URL in an attempt to attack a user's machine.
User interaction is required, as the URL has to be opened by right-clicking on the server entry and clicking on
Open Webpage.This PR introduces a client-side whitelist, which only allows
httpandhttpsschemes. We will also implement it in our public list.In future we should probably add a warning
QMessageBoxinforming the user that there's no guarantee the URL is safe (regardless of the scheme).Thanks a lot to https://positive.security for reporting us the RCE vulnerability privately.