Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(server): Add missing line breaks to --help output #5443

Merged
merged 1 commit into from
Jan 18, 2022
Merged

FIX(server): Add missing line breaks to --help output #5443

merged 1 commit into from
Jan 18, 2022

Conversation

felixsinger
Copy link
Contributor

Checks

Copy link
Member

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit type should be FIX as FORMAT is usually only used for formatting the source code itself (which is never visible from the running application) whereas this fixes an issue with the actual program's output.
And the scope should be server and not murmur (we are in the process of deprecating the term "murmur").

So overall it should be FIX(server): ...

@felixsinger felixsinger changed the title FORMAT(murmur): Add missing line breaks to --help output FIX(server): Add missing line breaks to --help output Jan 17, 2022
@felixsinger
Copy link
Contributor Author

Thanks for the clarification!

@Krzmbrzl
Copy link
Member

No problem :)

@Krzmbrzl Krzmbrzl added bug A bug (error) in the software server labels Jan 17, 2022
@felixsinger
Copy link
Contributor Author

Are you planning to backport this to the 1.4.x branch?

@Krzmbrzl
Copy link
Member

Given that this fixes a bug, yes a backport is due

@Krzmbrzl
Copy link
Member

Thanks for fixing this 👍

@felixsinger
Copy link
Contributor Author

Great, thanks :)

@felixsinger felixsinger deleted the fix/add-missing-line-breaks branch January 18, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug (error) in the software server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants