-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX(server): Add missing line breaks to --help output #5443
FIX(server): Add missing line breaks to --help output #5443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit type should be FIX
as FORMAT
is usually only used for formatting the source code itself (which is never visible from the running application) whereas this fixes an issue with the actual program's output.
And the scope should be server
and not murmur
(we are in the process of deprecating the term "murmur").
So overall it should be FIX(server): ...
Signed-off-by: Felix Singer <[email protected]>
Thanks for the clarification! |
No problem :) |
Are you planning to backport this to the 1.4.x branch? |
Given that this fixes a bug, yes a backport is due |
Thanks for fixing this 👍 |
Great, thanks :) |
Checks