Backport "FIX(client): resolve list tags, etc. polluting log" to 1.4.x #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in mumble-voip#4491, mumble-voip#4986 and mumble-voip#5430, since the changes to the chat in the 1.4.x release, some tags would "pollute" the rest of the log, i.e. cause future log entries to be contained within them. The source of the issue seems to be that the `insertBlock` method of `QTextCursor` appears to correspond to the `<p>` HTML tag. The `<p>` tag may only contain inline elements, but `QTextEdit` will not fail outright when inserting block-level elements and will instead attempt to correct the invalid input which results in the behaviour reported in the above issues (as far as I can tell). My proposed solution is to use the `insertFrame` method for all messages. Fixes mumble-voip#4491 (cherry picked from commit ae097d6)
1 task
davidebeatrici
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
masterto1.4.x:Questions ?
Please refer to the Backport tool documentation