CHANGE(client): Disable RNNoise by default #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
approved these changes
May 11, 2022
|
Unfortunately there hasn't been much development around RNNoise in the past few years, maybe we should resort to a fork instead. |
In the 1.4.230 release, we enabled RNNoise by default as there have been lots of reports of how well it works. However, after the release we saw numerous reports complaining about bad audio quality, which was traced back to having RNNoise enabled. For some reason the outcome of having RNNoise enabled is very different in different scenarios. Sometimes it works miraculously well and other times it worsens the audio quality to an unbearable level. There seems to be a higher chance of RNNoise messing up, when using Windows, but the same effect has also been observed on Linux. It might also depend on the quality of the used microphone (better quality = less noise => RNNoise starts doing weird stuff), but we don't have any definitive clues yet. Because of this, we will change the default noise cancelling mode back to Speex so that everyone for whom RNNoise actually works, cna enable it, but we don't kill the experience for many folks by using an unsuitable default value. Fixes mumble-voip#5448
Krzmbrzl
force-pushed
the
change-disable-rnnoise-by-default
branch
from
7885104
to
c297c7b
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 1.4.230 release, we enabled RNNoise by default as there have been
lots of reports of how well it works. However, after the release we saw
numerous reports complaining about bad audio quality, which was traced
back to having RNNoise enabled.
For some reason the outcome of having RNNoise enabled is very different
in different scenarios. Sometimes it works miraculously well and other
times it worsens the audio quality to an unbearable level.
There seems to be a higher chance of RNNoise messing up, when using
Windows, but the same effect has also been observed on Linux. It might
also depend on the quality of the used microphone (better quality = less
noise -> RNNoise starts doing weird stuff), but we don't have any
definitive clues yet.
Because of this, we will change the default noise cancelling mode back
to Speex so that everyone for whom RNNoise actually works, cna enable
it, but we don't kill the experience for many folks by using an
unsuitable default value.
Fixes #5448
Checks