FEAT(client, server): Add more control over UDP stream. #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
irakr
force-pushed
the
fix-5517
branch
7 times, most recently
from
8a47f2a
to
596f17f
Compare
As requested in mumble-voip#5517 this commit implements the ability to control the inbound and outbound UDP audio stream by providing additional options in the network settings. The client and the server works together to provide these individual controls. An additional section called "UDP stream mode" has been added. Each of the options can be selected to specify the behaviour of the UDP as well as TCP stream. Also a protobuf message component called "disable_udp_mode" is added under UserState message which is used to force the server to use TCP mode only. Implements mumble-voip#5517 Co-Authored-By: Krzmbrzl <[email protected]>
|
@Krzmbrzl Are the changes under src/tests/TestSettingsJSONSerialization/ good? |
|
I will have a look at this eventually but atm I have too many things piling up on my todo-list and too little time to work on everything. I'll come back to reviewing this once I have chopped away some of the other stuff... |
|
No worries. Take your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #5517 this commit implements the ability to control the inbound and outbound UDP audio stream by providing additional options in the network settings. The client and the server works together to provide these individual controls.
An additional section called "UDP stream mode" has been added. Each of the options can be selected to specify the behaviour of the UDP as well as TCP stream.
Also a protobuf message component called "disable_udp_mode" is added under UserState message which is used to force the server to use TCP mode only.
Implements #5517
Co-Authored-By: Krzmbrzl [email protected]
Checks