Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower setuptools requirement (currently >=61) #4

Closed
kimheino opened this issue Sep 30, 2022 · 4 comments
Closed

Lower setuptools requirement (currently >=61) #4

kimheino opened this issue Sep 30, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@kimheino
Copy link

From munin irc:

12:18        bcg | Penguinpee: Interesting. Any plans for rhel9 rpm?
12:25 Penguinpee | Do you happen to know the version of setuptools shipped in el9? I have to hit the road. I can try doing a scratch build
                 | later on to find out if the version of setuptools is new enough. It needs to be >=61.
12:28        bcg | python3-setuptools-53.0.0-10.el9.noarch
12:32        bcg | PyMunin3 looks nice and I might use that for my plugins, but rhel9 support is mandatory for me.

If that matters, I'm the maintainer of munin.rpm in EPEL and Fedora. I've also written 10+ plugins for it in Python.

@penguinpee penguinpee self-assigned this Sep 30, 2022
@penguinpee penguinpee added the enhancement New feature or request label Sep 30, 2022
@penguinpee
Copy link
Collaborator

Besides RHEL9 this also applies to the current releases of Fedora:

F35: 57.4.0
F36: 59.6.0

Only F37 (62.6.0), currently in beta, has new enough setuptools to support building this package.

So, lowering the requirements will make PyMunin3 available for a broader audience.

For the nitty gritty: https://setuptools.pypa.io/en/latest/history.html#id184 (short) or #3067 (long).

@penguinpee penguinpee changed the title RHEL9 has python3-setuptools-53.0.0-10.el9.noarch Lower setuptools requirement (currently >=61) Sep 30, 2022
@penguinpee
Copy link
Collaborator

I've lowered the setuptools requirement, just to hit another roadblock: setuptools_scm.

The requirement is setuptools_scm[toml]>=6.2, which is only met in f36. In f35 it's 6.0.1, but since f35 will be retired soon, I can't be bothered. For el9 setuptools_scm has not been released at all it seems: https://src.fedoraproject.org/rpms/python-setuptools_scm. I suppose I could nudge @hroncok 🐍 as to why.

For a preview see: https://copr.fedorainfracloud.org/coprs/gui1ty/PyMunin3/build/4881892/

For anyone who lives by the motto Who says I can't, the only runtime requirement is a recent Python3 version (>=3.7). That means a local install should work without problems:

sudo dnf localinstall python3-PyMunin3-3.0.2-1.fc36.noarch.rpm

Disclaimer: YMMV!

@hroncok
Copy link
Contributor

hroncok commented Oct 3, 2022

The requirement is setuptools_scm[toml]>=6.2, which is only met in f36. In f35 it's 6.0.1, but since f35 will be retired soon, I can't be bothered. For el9 setuptools_scm has not been released at all it seems: https://src.fedoraproject.org/rpms/python-setuptools_scm. I suppose I could nudge @hroncok snake as to why.

RHEL 9 CRB repository (available and required for EPEL 9) contains python3-setuptools_scm, however also version 6.0.1.

As with the setuptools 62+ requirement, I see 2 options:

  • use the new and fancy stuff
  • build in old stable environments

You cannot have both at the same time. Either don't use the new stuff upstream or patch it out downstream in EL 9. Sorry about that.

You may of course open a RHEL Bugzilla to request the features of setuptools and setuptools_scm you want, but without a customer ticket, there is no guarantee it will be aded.

penguinpee added a commit that referenced this issue Oct 3, 2022
- re-introduce setup.cfg
- move pyproject.toml project table to setup.cfg
- setuptools_scm[toml]>=6 for el9

Build works perfectly fine with the lower setuptools_scm[toml].
@penguinpee
Copy link
Collaborator

Roadblock has been cleared. Next release will be available for all current Fedora releases as well as el9. For the impatient:

https://copr.fedorainfracloud.org/coprs/gui1ty/PyMunin3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants