Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze on opening when using local time signature and voice2 #26001

Closed
4 tasks done
mercuree opened this issue Jan 6, 2025 · 4 comments · Fixed by #26100
Closed
4 tasks done

Freeze on opening when using local time signature and voice2 #26001

mercuree opened this issue Jan 6, 2025 · 4 comments · Fixed by #26100
Assignees
Labels
corruption Issues involving file corruption crash Issues involving a crash of MuseScore P2 Priority: Medium

Comments

@mercuree
Copy link
Contributor

mercuree commented Jan 6, 2025

Issue type

Crash or freeze

Description with steps to reproduce

This issue is based on a report from https://musescore.org/en/node/373586
UPD. Also reported before https://musescore.org/en/node/373427

I don't know the exact way how the user got this result, but I managed to reproduce it from scratch

  1. Create empty score from treble clef template or piano
  2. Add 12/8 local time signature
  3. Enter 12 eighth notes
  4. Enter eighth and eleventh notes for voice 2
  5. Remove all rests from voice 2
  6. Save and close score
  7. Open score again - Freeze

I can't reproduce in Musescore 4.3.2 because it doesn't allow to enter voice 2 in an arbitrary position.
I think this is a regression since 4.4.0

Supporting files, videos and screenshots

freeze_local_time_signature_voice2.mp4

What is the latest version of MuseScore Studio where this issue is present?

MuseScore Studio version (64-bit): 4.5.0-250060307, revision: github-musescore-musescore-0b07b33

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

windows 10

Additional context

No response

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added crash Issues involving a crash of MuseScore regression MS4 Regression on a prior release labels Jan 6, 2025
@oktophonie oktophonie added P2 Priority: Medium corruption Issues involving file corruption labels Jan 7, 2025
@mathesoncalum
Copy link
Contributor

I carried out quite a long investigation of this last night/this morning (no luck yet). It looks like local time signatures + voices have been problematic since at least MS3. As @mercuree points out, #23911 introduced another way to reach this corruption, but the root cause has been around for a very long time.

timesigvoices.mov

@oktophonie oktophonie removed the regression MS4 Regression on a prior release label Jan 8, 2025
@mercuree
Copy link
Contributor Author

mercuree commented Jan 8, 2025

In MS3 you get a corruption message. I got a lot of these in MS4 too, but it didn't always result in a freeze when opening. Is it possible to fix the freeze at least at this point?
Yes, local time signature is a rarely used feature, but we've already received two complaints on the forum in a short period of time.

@mathesoncalum
Copy link
Contributor

mathesoncalum commented Jan 8, 2025

I had a bit of trouble reproducing the freeze earlier but I can do now - I'll look into it.

Edit: It appears the freeze (again, not the underlying corruption) was introduced with #23783. The changes to Measure::fillGap cause an infinite loop inside Measure::checkMeasure.

@oktophonie oktophonie assigned mike-spa and unassigned mathesoncalum Jan 9, 2025
@mike-spa mike-spa moved this from To do to In Progress in MuseScore Studio 4.5 Jan 15, 2025
mike-spa added a commit to mike-spa/MuseScore that referenced this issue Jan 15, 2025
Resolves: musescore#26001

Resolves the freeze that occurs when opening the corrupted file. Also resolves the problem which causes the corruption in the first place.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jan 16, 2025
Resolves: musescore#26001

Resolves the freeze that occurs when opening the corrupted file. Also resolves the problem which causes the corruption in the first place.

Backport of musescore#26100, commit 4
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this issue Jan 16, 2025
Resolves: musescore#26001

Resolves the freeze that occurs when opening the corrupted file. Also resolves the problem which causes the corruption in the first place.

Backport of musescore#26100, commit 4
@Jojo-Schmitz
Copy link
Contributor

I can't reproduce the issue with Mu3

mike-spa added a commit to mike-spa/MuseScore that referenced this issue Jan 16, 2025
Resolves: musescore#26001

Resolves the freeze that occurs when opening the corrupted file. Also resolves the problem which causes the corruption in the first place.
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this issue Jan 16, 2025
Resolves: musescore#26001

Resolves the freeze that occurs when opening the corrupted file. Also resolves the problem which causes the corruption in the first place.

Backport of musescore#26100, commit 4
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this issue Jan 18, 2025
Resolves: musescore#26001

Resolves the freeze that occurs when opening the corrupted file. Also resolves the problem which causes the corruption in the first place.

Backport of musescore#26100, commit 4
@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore Studio 4.5 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
corruption Issues involving file corruption crash Issues involving a crash of MuseScore P2 Priority: Medium
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants