Better support for single-line block components #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a block component is invoked on a single line, indentation gets
confused. For instance:
{{#link-to 'some.route'}}Example <span>text</span>{{/link-to}}
The next line gets indented with one shiftwidth. This commit avoids the
issue by checking against another pattern.
It also renames the variables "lnum" to "plnum", and "line" to "pline"
for better clarity ("previous" line).
|
Why did you delete this? Has this been solved in another PR? |
|
I tried the current master, and it seems not to be a problem anymore, so I'm guessing it got fixed at some point. |
|
Cool, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a block component is invoked on a single line, indentation gets confused. For instance:
The next line gets indented with one shiftwidth. This commit avoids the issue by checking against another pattern.
It also renames the variables "lnum" to "plnum", and "line" to "pline" for better clarity ("previous" line).