Fix L10n: messages-compiled.json are not compiled automatically by vite #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbucksch
requested changes
Jun 30, 2024
| import { messages as ru } from './locales/ru/messages-compiled.json'; | ||
| import { messages as sv } from './locales/sv/messages-compiled.json'; | ||
| import { messages as uk } from './locales/uk/messages-compiled.json'; | ||
| import { messages as ar } from './locales/ar/messages.json?lingui'; |
There was a problem hiding this comment.
Is it possible to keep the 'messages.compiled.json' (preferably with . instead of -) instead of the ?lingui query? I think that would be safer, avoiding confusion, and might also work better with the installed version of the app.
There was a problem hiding this comment.
It doesn't seem possible, in the source code it searches for .po or ?lingui. And there isn't a way to change that.
https://github.com/lingui/js-lingui/blob/0f6661799acfb62c4d169cacc8f6867278263f0e/packages/vite-plugin/src/index.ts#L11
benbucksch
reviewed
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
messages-compiled.json@lingui/vite-pluginadded?linguito message.json imports for compilation when running vite@lingui/vite-plugintoe2/electron.vite.cofig.ts