Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2Window: Close window from main process #210 #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jermy-c
Copy link
Collaborator

@jermy-c jermy-c commented Oct 18, 2024

  • Sends IPC message to the main process to close the window from there

@benbucksch
Copy link
Collaborator

benbucksch commented Oct 18, 2024

Why? Can you please describe the specific bug that you are trying to fix here? In which situations does it appear?

Why do you think that this is the right fix?

@jermy-c
Copy link
Collaborator Author

jermy-c commented Oct 18, 2024

Why? Can you please describe the specific bug that you are trying to fix here? In which situations does it appear?

This is just a temporary workaround for a window that doesn't close with the window.close(). Remember the bug where the OAuth2 window doesn't close for Yahoo and AOL mail? This is a workaround for that in the meantime. It seems like when the redirect url is a different domain then window.close() doesn't work because the new domain is considered a new entry. I couldn't find a way to set the opener otherwise that would be a better solution.

As of Chromium 88, window.close() succeeds if the new window/tab has an opener or if the back/forward stack contains fewer than two entries.

Why do you think that this is the right fix?

I don't think this is the right fix but it is the only solution I have at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants