Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate render by using value cache key #518

Merged
merged 4 commits into from
Dec 13, 2022
Merged

fix: duplicate render by using value cache key #518

merged 4 commits into from
Dec 13, 2022

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Dec 12, 2022

not a reference cache key related #517

@luwes luwes self-assigned this Dec 12, 2022
@luwes luwes requested a review from a team as a code owner December 12, 2022 19:27
@vercel
Copy link

vercel bot commented Dec 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 0:20AM (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 0:20AM (UTC)
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 0:20AM (UTC)
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 0:20AM (UTC)
elements-demo-vue ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 0:20AM (UTC)

@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited
Loading

Codecov Report

Merging #518 (53e6030) into main (8ee139d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   83.05%   83.07%   +0.02%     
==========================================
  Files          26       26              
  Lines        6160     6170      +10     
  Branches      260      265       +5     
==========================================
+ Hits         5116     5126      +10     
  Misses       1043     1043              
  Partials        1        1
Impacted Files Coverage Δ
packages/mux-player/src/html.ts 96.68% <100.00%> (+0.19%) ⬆️

cjpillsbury
cjpillsbury requested changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of questions before merging

packages/mux-player/src/html.ts Show resolved Hide resolved
packages/mux-player/src/html.ts Show resolved Hide resolved
cjpillsbury
cjpillsbury approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with an ask for a followup ticket to be created (at least internally) for the GC concerns.

@luwes luwes merged commit 2b8c485 into muxinc:main Dec 13, 2022
@luwes luwes deleted the fix-dup-render branch January 31, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev left review comments

@cjpillsbury cjpillsbury cjpillsbury approved these changes

Assignees

@luwes luwes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luwes @gkatsev @cjpillsbury