Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use webp format for less bandwidth #525

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

dylanjha
Copy link
Contributor

@dylanjha dylanjha commented Dec 16, 2022

  • use webp format for thumbnail and storyboard

Even with signed URLs, this works with the same token. See:

Thumbnail token:

And the storyboard token:

@dylanjha dylanjha requested a review from a team as a code owner December 16, 2022 22:24
@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 10:49PM (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 10:49PM (UTC)
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 10:49PM (UTC)
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 10:49PM (UTC)
elements-demo-vue ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 10:49PM (UTC)

Copy link
Contributor

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Looks like goes from ~220KB transferred to ~131KB

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #525 (d6a427f) into main (5c27059) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          26       26           
  Lines        6183     6184    +1     
  Branches      266      266           
=======================================
+ Hits         5139     5140    +1     
  Misses       1043     1043           
  Partials        1        1           
Impacted Files Coverage Δ
packages/mux-player/src/helpers.ts 87.94% <100.00%> (+0.05%) ⬆️

@dylanjha
Copy link
Contributor Author

@gkatsev yeah that's what I'm seeing for the thumbnail, for the storyboard I'm seeing:

  • 212 KB for jpg
  • 145 KB for webp

Also, this asset is a short duration, so it only has 24 images in the storyboard. Longer assets will max out at 100 images iirc

@dylanjha dylanjha merged commit 9441de4 into muxinc:main Dec 16, 2022
@dylanjha dylanjha deleted the dj/webp-thumbnail-and-storyboard branch December 16, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants