-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing application/json-seq #110
base: master
Are you sure you want to change the base?
Conversation
Add the `slurp` argument to all `_Program.input*()` methods, and pass it through, so it's possible to supply it with every method. But most importantly the `_Program.input()`, which also accepts `text`.
Let Python give us the length of the "bytes" it already knows, instead of doing an strlen(). This improves performance a bit.
CI failed seemingly due to pypi.org certificate verification issues. |
Looks like the only broken test job is |
Just to check I've understood, it seems like there are two main changes here:
Specifically, when passing in Have I understood that correctly? |
Yes. I did it this way, because the Thanks for the review! |
I think you could make an argument for a Given the existing API, I think the least ambiguous approach might be to leave the existing methods as they are, and instead add two new methods, |
Support parsing RS-separated streams, as per RFC 7464.
That works for me, updated! |
There's still SSL certificate verification problem in |
I've just dropped support for Python 3.5, seeing as we don't build wheels for it anyway and usage seems low. |
I think this is good to go with the new methods. I'd prefer not to add There's also missing tests for outputting text sequences, but I'm happy to add those tests once this is merged. |
Sorry, I'm on a conference trip and don't have time to continue this right now. I'll get back to this the week after next one. |
Support parsing RS-separated streams, as per RFC 7464.
Hi Michael, here are some (possibly) useful changes separated from my stream parsing support, freshly rebased.
Would be glad to hear your comments and fix it up as necessary!