Implement Stringable interface on Enum

[jdecool]

Enum class has a __toString, so it would be great to implements the new Stringable interface.

As the interface is not available for php < 8, I've had the symfony/polyfill-php-80 implemented a polyfill.

[mnapoli]

Hey hey, thanks!

I'd love to skip requiring the polyfill: this package is used everywhere, and polyfills add extra (often useless) code to download and packaged applications.

I'm torn between:

• we shouldn't do anything
• or we should do a new release with a PHP 8 requirement, but since this is a highly used library this could cause issues for a lot of people

How is the Stringable useful in practice?

[jdecool]

I'm torn between:

• we shouldn't do anything
• or we should do a new release with a PHP 8 requirement, but since this is a highly used library this could cause issues for a lot of people

Maybe another possibility is to implement the polyfill directly in the library, it's just a single interface with a classmap definition for the autoloading.

How is the Stringable useful in practice?

In a project I work on, I use a library which types a lot of arguments method with the Stringable interface.
So I need to implement the interface on each enums. As they already implement the __toString method, I thought it might be a good idea to do it right here in the library. Don't you think ?

[mnapoli]

👍 I'm actually +1 on re-implementing the polyfill interface. That's usually stuff I don't want to maintain, but here given the impact of this project I'd rather not take any risk.

[jdecool]

I've just updated the PR

[willemstuursma]

LGTM

[jdecool]

Hi @mnapoli, do you have an opinion on this PR ?

Just to know, if I should closed it or not :)

[drealecs]

symfony/polyfill-php80 has no if condition there: https://github.com/symfony/polyfill-php80/blob/main/Resources/stubs/Stringable.php
Is there a way to control what would composer use in the classmap for this interface as a file? I guess it should be only 1 file and it doesn't matter which one of them will get here if both would be available.
Do you see a issue where symfony might be included after this one and having no if condition it would fail?

[mnapoli]

Oh good point 🤔

[jdecool]

It doesn't matter which one is used as both polyfill "emulate" the same interface.

The classmap autoloads will result in an associative array which associate a class with a file which implement this one.
From the Composer autoload view, only one file will be loaded.

[mnapoli]

Sorry for the delay, I lost track of it. Let's do this.

Thanks @jdecool