fixup! Add idleConnectionTimeout to pool options

Use conn.end instead of conn.destroy for closing idle connections
mysqljs · May 31, 2019 · 6633202 · 6633202
1 parent fc44254
commit 6633202
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/PoolConnection.js b/lib/PoolConnection.js
@@ -5,6 +5,8 @@ var Events     = require('events');
 module.exports = PoolConnection;
 inherits(PoolConnection, Connection);
 
+function _noop() {}
+
 function PoolConnection(pool, options) {
   Connection.call(this, options);
   this._pool  = pool;
@@ -34,7 +36,7 @@ PoolConnection.prototype.release = function release() {
 
   if (this._pool.config.idleConnectionTimeout) {
     this._idleTimeout = setTimeout(
-      this.destroy.bind(this),
+      this._realEnd.bind(this, _noop),
       this._pool.config.idleConnectionTimeout
     );
   }