node>=v9.9.0, assert should use strict mode #134

aladdin-add · 2018-08-02T09:47:37Z

node>=9.9.0

var assert = require('assert'); // invalid, should report an error

var assert = require('assert').strict; // valid

mysticatea · 2018-08-02T12:34:06Z

Thank you for this issue.

However, this is intentional.
Node.js community intended to deprecate four methods (assert.equal, assert.deepEqual, assert.notDeepEqual, and assert.notEqual) rather than all of the non-strict methods. See the commit.

…ea#139) * feat: Use enhanced-resolve for imports * chore: Improve the metadata from "ImportTarget" * chore: remove "enhanced-resolve" from "no-hide-core-modules" * test: Add a test for mysticatea#66 * feat!: Allow ts paths aliases (mysticatea#84) * feat: Allow for "allowImportingTsExtensions" (mysticatea#134) * feat: Add test for import maps (mysticatea#147) * Update lib/util/import-target.js Co-authored-by: Sebastian Good <[email protected]> * test: Add test for n/no-missing-require eslint/use-at-your-own-risk * chore: Remove esbuild * feat: Allow for settings.cwd to be used before process.cwd * chore: replace reference to eslint/use-at-your-own-risk * chore: Remove more unused packages * chore: update rule test options to flat config * fix: incorrect env in tests --------- Co-authored-by: 唯然 <[email protected]>

mysticatea closed this as completed Aug 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

node>=v9.9.0, assert should use strict mode #134

node>=v9.9.0, assert should use strict mode #134

aladdin-add commented Aug 2, 2018

mysticatea commented Aug 2, 2018 •

edited

Loading

node>=v9.9.0, assert should use strict mode #134

node>=v9.9.0, assert should use strict mode #134

Comments

aladdin-add commented Aug 2, 2018

mysticatea commented Aug 2, 2018 • edited Loading

mysticatea commented Aug 2, 2018 •

edited

Loading